Extend KeyDownTriggerBehavior with Modifiers and ability to handle already handled events#853
Conversation
…nts, and modifier keys
Irina-Konovalova
force-pushed
the
key-down-trigger-behavior-improvements
branch
from
6b836a3 to
8b01b15
Compare
|
@dotnet-policy-service agree company="ECIERGE SOFTWARE DEV INC" |
There was a problem hiding this comment.
I think this is a great PR. I love the additional functionality, and I appreciate the coding style such as using guard clauses. However, I dislike the repeated calls to InputKeyboardSource.GetKeyStateForCurrentThread. I do love small purposeful helper functions, but not at the expense of ideal behavior. Let's see about moving the state check into CheckModifiers and inlining IsDown inside Match using the state retrieved in CheckModifiers.
There's also a somewhat trivial code styling question spawned by this PR regarding the ordering of class members. Hoping to get a definitive answer on that soon.
- Consolidate modifier state retrieval into CheckModifiers - Inline IsDown logic into Match - Remove repeated GetKeyStateForCurrentThread calls - Update XML documentation to match new signatures
Avid29
left a comment
Avid29
left a comment
There was a problem hiding this comment.
I pulled it down and tested it this time. Works great, just missing some namespace references in order to compile, but it also introduces a breaking change😬! I left a comment for how we can address that.
| using Microsoft.Xaml.Interactivity; | ||
| using Windows.System; |
There was a problem hiding this comment.
| using Microsoft.UI.Input; | |
| using Microsoft.Xaml.Interactivity; | |
| using Windows.System; | |
| using Windows.UI.Core; |
Missing some referenced namespaces
| return; | ||
| } | ||
|
|
||
| if (!CheckModifiers()) |
There was a problem hiding this comment.
Upon further consideration, this is actually a breaking change. In order to retain the existing behavior, we need to introduce a new property that declares whether or not to check for modifiers. Its default value needs to be false.
2 participants
Fixes
This PR extends
KeyDownTriggerBehavior.PR Type
What kind of change does this PR introduce?
KeyDownTriggerBehaviorwithModifiersand ability to handle already handled events.What is the current behavior?
KeyDownTriggerBehaviordoes not support modifier keys or PreviewKeyDown, which limits its use in keyboard navigation scenarios.What is the new behavior?
This PR extends
KeyDownTriggerBehaviorby adding support for modifier keys, PreviewKeyDown, and handled events. It also updates the XML documentation.PR Checklist
Please check if your PR fulfills the following requirements:
Other information